Code Monkey home page Code Monkey logo

Comments (9)

JiLiZART avatar JiLiZART commented on July 30, 2024 1

Maybe I could apply the lowercase here ? I don't know if there's any other implications, but in my experience all bbcode tags should be fine lower-cased.

Yes, TagNode is a good way to lowercase tag.

from bbob.

JiLiZART avatar JiLiZART commented on July 30, 2024 1

I just published 2.5.3 you can try

from bbob.

skipjack avatar skipjack commented on July 30, 2024

Maybe reactPreset.extend does work but the example doesn't spread tags back in (...tags) like it does under the hood when extending presetHTML5? I used the example which excludes that spread...

  const preset = reactPreset.extend((tags, options) => ({
+   ...tags,
    quote: node => ({
      tag: "blockquote",
      content: node.content
    })
  }))

If this is the issue I'd be happy to submit a PR to update the docs.

UPDATE: That does seem to be the issue, I'll submit a PR (#29).

from bbob.

skipjack avatar skipjack commented on July 30, 2024

@JiLiZART take a look when you get a chance and let me know your thoughts. I'm pretty much done for now (have been integrating into a project it over the last day or two) but I'm still happy to help with these issues. I submitted PRs for the obvious fixes/updates but I wanted to hear what you had to say on the other things before moving forward.

Again, thanks for your work on this project.

from bbob.

skipjack avatar skipjack commented on July 30, 2024

Maybe I could apply the lowercase here? I don't know if there's any other implications, but in my experience all bbcode tags should be fine lower-cased.

from bbob.

JiLiZART avatar JiLiZART commented on July 30, 2024

@skipjack Thanks for contributing! Any help would be helpful.
I think this will make the project only better.

from bbob.

meodemsao avatar meodemsao commented on July 30, 2024

i use version 2.5.2

code sandbox

[ALT=http://media.thethaovanhoa.vn/2013/06/22/07/32/Pirlo.jpg]Pirlo[/ALT]

has error

Warning: <ALT /> is using incorrect casing. Use PascalCase for React components, or lowercase for HTML elements. in ALT (created by Component) in span (created by Component) in Component (created by App) in App

i seen #42 seem fix this issue ?

from bbob.

meodemsao avatar meodemsao commented on July 30, 2024

@JiLiZART thanks, it's work for me

from bbob.

JiLiZART avatar JiLiZART commented on July 30, 2024

I freeze this due inactivity

from bbob.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.