Comments (2)
I think I have found the root cause:
according to https://github.com/jhump/protoreflect/blob/main/dynamic/json.go#L386,
if dataType=int64, it will become strings due to strconv.FormatInt()
, So I have a question, why we don't use https://github.com/jhump/protoreflect/blob/main/dynamic/json.go#L399 for dataType=int64
btw, I found the similar issue for uint64, https://github.com/jhump/protoreflect/blob/main/dynamic/json.go#L403
from protoreflect.
@Big-big-orange, this is part of the spec for the JSON format of protobuf messages: https://protobuf.dev/programming-guides/proto3/#json
64-bit integers are represented using JSON strings because JSON numbers are usually stored as IEEE 64-bit floats, which cannot represent all 64-bit integers. This is related to protocolbuffers/protobuf#12994.
Also, FWIW, I recommend users migrate their usage of "github.com/jhump/protoreflect/dynamic" to instead use "google.golang.org/protobuf/types/dynamicpb". A (hopefully soon) v2 of this repo will remove the dynamic package (and others) since this functionality is now provided by the core Protobuf runtime for Go.
from protoreflect.
Related Issues (20)
- panic: invalid type: got *dynamicpb.Message when GetExtension HOT 6
- can not FindMessage from linked files HOT 2
- Breaking changes in the protocompile/ast dependency
- EnumBuilder panics if it contains EnumValue with explicitly set Number HOT 1
- might not be bug: false duplication report due to use of relative path instead of absolute path HOT 6
- SIGSEGV: panic: runtime error: invalid memory address or nil pointer dereference in v1.15.2 HOT 8
- Protoreflect doesn't fall back to to v1alpha when a gRPC unimplemented response is returned HOT 1
- String escaping in protoprint is wrong HOT 1
- First enum value must be 0 in proto3 [protoprint] HOT 2
- missing `{}` after printing option HOT 5
- Upgrade protocompile to v0.7.0 HOT 3
- go build error HOT 3
- Regression upgrading from v1.14.1 to v1.15.4: extensions are resolved recursively instead of non-recursively HOT 1
- Regression upgrading from v1.14.1 to v1.15.4: absolute paths no longer accepted by parser.ParseFilesButDoNotLink HOT 3
- Regression upgrading from v1.14.1 to v1.15.4: new mustBeSource constraint/check HOT 5
- Stub structure and Methods will relay on protobuf API V2 HOT 13
- Fail to compile proto file HOT 2
- Tests broken with google.golang.org/protobuf v1.33.0
- invalid memory address or nil pointer dereference HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protoreflect.