Code Monkey home page Code Monkey logo

Comments (2)

Big-big-orange avatar Big-big-orange commented on June 10, 2024

I think I have found the root cause:

according to https://github.com/jhump/protoreflect/blob/main/dynamic/json.go#L386,
if dataType=int64, it will become strings due to strconv.FormatInt(), So I have a question, why we don't use https://github.com/jhump/protoreflect/blob/main/dynamic/json.go#L399 for dataType=int64

btw, I found the similar issue for uint64, https://github.com/jhump/protoreflect/blob/main/dynamic/json.go#L403

from protoreflect.

jhump avatar jhump commented on June 10, 2024

@Big-big-orange, this is part of the spec for the JSON format of protobuf messages: https://protobuf.dev/programming-guides/proto3/#json

64-bit integers are represented using JSON strings because JSON numbers are usually stored as IEEE 64-bit floats, which cannot represent all 64-bit integers. This is related to protocolbuffers/protobuf#12994.

Also, FWIW, I recommend users migrate their usage of "github.com/jhump/protoreflect/dynamic" to instead use "google.golang.org/protobuf/types/dynamicpb". A (hopefully soon) v2 of this repo will remove the dynamic package (and others) since this functionality is now provided by the core Protobuf runtime for Go.

from protoreflect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.