HP SmartArray adapters should be treated similar to MegaRaid about puppet-smartd HOT 4 CLOSED

@razorsedge Sorry for the delay in responding, github email notifications continue to be MIA most of the time for me.

You've obviously encountered a case that was never considered by the API. device_options is a hash so in your example the '/dev/cciss/c0d0' key is being redefined over and over again.

I think the API needs to be changed to devices being an Array of Array or an Array of Hash with device_options being removed. Something like:

class { 'smartd':
  devices => [
    [ '/dev/cciss/c0d0', '-d cciss,0 -a -o on -S on' ],
    [ '/dev/cciss/c0d0', '-d cciss,1 -a -o on -S on' ],
    [ '/dev/cciss/c0d0', '-d cciss,2 -a -o on -S on' ],
    [ '/dev/cciss/c0d0', '-d cciss,3 -a -o on -S on' ],
    [ '/dev/cciss/c0d0', '-d cciss,4 -a -o on -S on' ],
    [ '/dev/cciss/c0d0', '-d cciss,5 -a -o on -S on' ],
  ],
}

or

class { 'smartd':
  devices  => [
    { 'dev' => '/dev/cciss/c0d0', options => '-d cciss,0 -a -o on -S on' },
    { 'dev' => '/dev/cciss/c0d0', options => '-d cciss,1 -a -o on -S on' },
    ...
  ],
}

Another possibility would be to abandon both attributes and try to use a defined type but that would require setting a unique namevar for your case.

smartd::device { 'cciss1':
  device  =>  '/dev/cciss/c0d0',
  options => '-d cciss,1 -a -o on -S on',
}

What are your thoughts?

from puppet-smartd.

@jhoblitt I am kind of ambivalent. I know that right now I want to use Hiera data bindings to provide the settings with the possibility to merge parts of the hierarchy into the smartd.conf. This probably precludes defined types. A hash would allow for Hiera hash merging.

Long-term I would want fact discovery to automatically find all DASD block devices, figure out if they are behind hardware RAID, and apply the correct '/dev/cciss/c0d0', '-d cciss,4' '/dev/sdg', '-d megaraid,2' pairings to the smartd.conf.

from puppet-smartd.

Could you take a look at #9 and see if it covers your needs? I added a test based on your example.

from puppet-smartd.

#9 fixes it. Thanks.

from puppet-smartd.