Change Button Placement about videojs-theater-mode HOT 3 OPEN

Hey @casbboy, do you have a page or anything up that shows the problem? I built the plugin against video.js 5, and notice you're using video.js 6 syntax for the #addChild function. The indexopt (4) wasn't available when originally built, so this line is responsible for placing the theater mode button just before the fullscreen button:

https://github.com/jgubman/videojs-theater-mode/blob/master/src/videojs.theaterMode.js#L49

Here's what it's supposed to look like:
video.js 6.2: https://jsfiddle.net/qwv0n9m3/2/
video.js 5.19: https://jsfiddle.net/qwv0n9m3/

from videojs-theater-mode.

Hey @jgubman - It turns out a skin I had wasn't completing before running yours, so the skin had the same line for two other buttons, and so they'd get priority since would run after the theater mode button.

The skin has since added a "finished" trigger, so I wait for that and then run the theatermode.

I used to have my expand player function inside this:

player.on('theaterMode', function(elm, data) {
    if (data.theaterModeIsOn) {
      expandtaplayer();
    } else {
     expandtaplayer();
    }

But it would run upon load every time, so deleted the above and just went with....

$(document).on('click', ".vjs-theater-mode-control-open,.vjs-theater-mode-control-close", function() {
			  expandtaplayer();
			  });

Since that single function checks whether expanded or not yet.

Cheers!
Ryan

from videojs-theater-mode.

You can see the theater mode button in action here: https://www.traileraddict.com/thor-ragnarok/feature-trailer

from videojs-theater-mode.