Change order of package name about consult-org-roam HOT 7 CLOSED

Hi @artelse,
thanks for you interest in the package and you suggestion.
Since it sounds like a good idea to follow consult's naming conventions, I changed the repo's name and the whole code base to conform with that in commit e1ff4b1.

Thanks for that remark!

Can you please elaborate what warnings you observed?

from consult-org-roam.

These are the warnings:

Warning (comp): consult-org-roam.el:11:12: Warning: defcustom for ‘consult-org-roam-grep-func’ fails to specify containing group Disable showing Disable logging
Warning (comp): consult-org-roam.el:11:12: Warning: defcustom for ‘consult-org-roam-grep-func’ fails to specify containing group Disable showing Disable logging
Warning (comp): consult-org-roam.el:47:11: Warning: Unused lexical variable `node' Disable showing Disable logging
Warning (comp): consult-org-roam.el:82:2: Warning: docstring wider than 80 characters Disable showing Disable logging
Warning (comp): consult-org-roam.el:82:70: Warning: Unused lexical argument `require-match' Disable showing Disable logging

Some are because of more strict warnings in Emacs 29 I belief.

from consult-org-roam.

Thanks for sharing these warnings with me, @artelse.
I think they should be addressed by commit a6f3aed.
Could you check, whether those newly added changes resolve the a/m warnings?
Thanks in advance!

from consult-org-roam.

That commit fixes most of them, just one remaining, but that seems harmless:
Warning (comp): consult-org-roam.el:91:2: Warning: docstring wider than 80 characters Disable showing Disable logging
Thanks, I like this package, makes org-roam even more enjoyable to work with.

from consult-org-roam.

This should now be fixed with 8c5cb9d.
Thanks for reporting those warnings. Can we close this issue?

from consult-org-roam.

That resolved the last warning. Don't want to open another issue, but don't see a version string of the package in completion buffer.

from consult-org-roam.

Good point, thanks!
I added a version string and some commentary in commit 5ed4caa.
If you find any other issues, please let me know.

Best regards,
jgru

from consult-org-roam.