Code Monkey home page Code Monkey logo

Comments (6)

recrudesce avatar recrudesce commented on May 19, 2024

Now that you're adding a battery icon, maybe have a little status bar at the top that houses the battery icon, and then a web (if using online generation) or a little disk icon (if using local files). That way at a glance you can see the battery state, and also where the currently displayed image came from ?

Maybe this for the local files: https://www.flaticon.com/free-icon/hard-drive_494066

and this for generated files: https://www.flaticon.com/free-icon/global_591788

You could also change the battery icon to this when the battery is charging: https://www.flaticon.com/free-icon/lighting_3103277

from pycasso.

jezs00 avatar jezs00 commented on May 19, 2024

Sounds good. Considering we have a lot of possible icons we want to use:

  • Low battery warning (Currently square. Can probably replace with a nice icon from flaticon, for people who don't choose to have battery level always showing)
  • PiJuice failed to load (Currently X)
  • Battery level
  • Disk/Web/Test
  • Notification of failure to load default mode

We would, as you say, like to collect these in an invisible task bar. This is a little complicated as we can't just define a location for each image, we would have to collect the icons we want to display, then display them in order, EG right to left.

I think the possibility for extension to this makes sense to create a new icon_handler.py and offload all icon management to this. This way the icon management object can be created at the start of the program, and whenever you want to add an icon, we can use an add_icon(icon) function to add it to the list. Internally it will hold a list of icons. Finally when we want to actually draw the image, we can pass the image object to a draw_icons(image) function and it handles the logic of drawing the icons.

constants.py to hold icon types and file paths.

from pycasso.

recrudesce avatar recrudesce commented on May 19, 2024

you have a little space at the top/bottom of the image, because it seems to crop the images in such a way that leaves a black bar at the top/bottom (at least all the ones that i've generated have). so maybe just make the icons 16x16 and put them in a little bar at the top like Android/iOS does on phones ?

Agree with all other sentiments as well - palm it off to another handler, definitely.

from pycasso.

jezs00 avatar jezs00 commented on May 19, 2024

I'd probably just put the images in with configurable opacity so users can decide how they'd like to see it. If users are getting an image that's not cropped, it's going to be different for different external image sizes, different screens and different providers. Something with configurable opacity or color will probably work for everyone, I could probably also config out the icon size so you can choose whatever suits your build.

it seems to crop the images in such a way that leaves a black bar at the top/bottom

What provider are you using, or are you using external images? Ideally I was hoping to always have an option for all users to completely fill their frame, whether through cropping or infilling.

from pycasso.

recrudesce avatar recrudesce commented on May 19, 2024

What provider are you using, or are you using external images? Ideally I was hoping to always have an option for all users to completely fill their frame, whether through cropping or infilling.

Stability - I always get a small black bar at the top and bottom for any generated image.

image

from pycasso.

jezs00 avatar jezs00 commented on May 19, 2024

That's annoying, Stable Diffusion should just fit. I've logged #32 to investigate, will look into it.

from pycasso.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.