<base> breaks icons about svg-sprite-loader HOT 8 CLOSED

@davidspiess #25 (comment)

from svg-sprite-loader.

Unfortunately we can't have automatic universal solution.
Angular is just widespread case of <base> usage, which is easy to automate.

from svg-sprite-loader.

Why not always use an absolute path like in the solution mentioned by @kisenka? Shouldn't that fix the <base> problem completely?
At the moment i'm using something like this

<use xlink:href="${ window.location.href.split('#')[0] + icon }"></use>

from svg-sprite-loader.

Because absolute path changes when navigation (using history API) happened, so we have to update xlink:hrefs of all existing icons, that's why we listen to custom spriteLoaderLocationUpdated event in order to do it on time.

So actually you need both second and third point from the comment.

from svg-sprite-loader.

Thanks for the clarification :) I didn't think about the history api. More docs about the <base> issue would be a great addition 👍

from svg-sprite-loader.

My pleasure :)
Let us know if you have any ideas on custom event API.

from svg-sprite-loader.

@davidspiess BTW, would you like to make a PR regarding #30?

from svg-sprite-loader.

@princed right now i'm quite busy, but i'll dive into it this weekend :)

from svg-sprite-loader.