This bug could be filed under a number of different trackers, it is filed on the <a hr

I'm pretty sure it is a duplicate of this <a class="issue-link js-issue-link" data

<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="23

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Compose resources fail in Android Studio preview about compose-multiplatform HOT 5 CLOSED

malbanese commented on July 23, 2024 1

Compose resources fail in Android Studio preview

from compose-multiplatform.

Comments (5)

terrakok commented on July 23, 2024 1

I'm pretty sure it is a duplicate of this
#4476

from compose-multiplatform.

terrakok commented on July 23, 2024 1

#4965

from compose-multiplatform.

malbanese commented on July 23, 2024

@terrakok Looks similar.

Would it be viable to change the ResourceReader interface and local composition to not be internal?

compose-multiplatform/components/resources/library/src/commonMain/kotlin/org/jetbrains/compose/resources/ResourceReader.kt

Line 36 in fc90219

    
           internal val LocalResourceReader = staticCompositionLocalOf { DefaultResourceReader }

It's not a perfect solution, but would at least allow for customization when needed.

from compose-multiplatform.

terrakok commented on July 23, 2024

How will it help you?

from compose-multiplatform.

malbanese commented on July 23, 2024

In this case, it would help me get preview code working by allowing me to override it.

My current solution is to expose my own composition local with my own version of the resource fetching methods, which ultimately call into the JB versions (or not).

Beyond that, I think allowing for overrides of it does present some interesting opportunities, but they would all be niche use cases. I also admit, it would mean exposing the internals of resource storage, which may not be something the team wants to do.

For example:

In past apps we've exposed an option which allows the debug apps to swap string values with the backing keys, for visual debugging purposes.
It also opens up interesting opportunities to allow for remotely updatable strings, possibly without creating an explicit wrapper API.

Both points can be done by just wrapping the API, but they are interesting use-cases, at least.

from compose-multiplatform.

Recommend Projects