Code Monkey home page Code Monkey logo

Comments (16)

chrisjenx avatar chrisjenx commented on September 26, 2024 1

Yeah we're working on deploying a hot fix to users once that's done I'll create a sample for y'all

from compose-multiplatform.

chrisjenx avatar chrisjenx commented on September 26, 2024 1

Added Trace, easy to reproduce, any dialog with scrollable content, scroll SLOWLY and you'll eventually run out of memory

from compose-multiplatform.

chrisjenx avatar chrisjenx commented on September 26, 2024 1

Unfortunately, I wasn't able to successfully reproduce this crash. Memory usage on a small project from template was about 70 mb and didn't increase no matter how I scrolled. Could you please make a reproducible example?

Dang, OK, will try and create a sample project. Sorry about that

from compose-multiplatform.

chrisjenx avatar chrisjenx commented on September 26, 2024 1

Unfortunately, I wasn't able to successfully reproduce this crash. Memory usage on a small project from template was about 70 mb and didn't increase no matter how I scrolled. Could you please make a reproducible example?

Oh just checking this ONLY happens on a physical device, simulators are fine (faster/more ram from host machine)

from compose-multiplatform.

chrisjenx avatar chrisjenx commented on September 26, 2024 1

@mazunin-v-jb As requested:
DialogCrash.zip

Launch app on physical iPhone, open dialog, scroll slowly (will be jerky vs previous versions) and then will suddenly crash.

I should have noted it was the BasicAlertDialogs from the m3 lib

from compose-multiplatform.

chrisjenx avatar chrisjenx commented on September 26, 2024 1

Oh good, maybe a placebo, but 1.6.10 doesn't feel as smooth as 1.6.0 potentially related if it's over drawing, leaking, etc

from compose-multiplatform.

chrisjenx avatar chrisjenx commented on September 26, 2024 1

Tested 1.6.11, still crashing for me. Looks like it's something else :(

(It's actually worse after some more testing)

from compose-multiplatform.

chrisjenx avatar chrisjenx commented on September 26, 2024 1

Looks like this is resolved

from compose-multiplatform.

mazunin-v-jb avatar mazunin-v-jb commented on September 26, 2024

Hello!
I'll notify the team about that, however, a small reproducible example would really help. Could you please attach it once you've made it to your first message?

from compose-multiplatform.

mazunin-v-jb avatar mazunin-v-jb commented on September 26, 2024

Unfortunately, I wasn't able to successfully reproduce this crash. Memory usage on a small project from template was about 70 mb and didn't increase no matter how I scrolled.
Could you please make a reproducible example?

from compose-multiplatform.

chrisjenx avatar chrisjenx commented on September 26, 2024

Nvm mind, I tested on the foundation Dialog and the same thing, guessing it's an underlying skia issue from what I can tell.

from compose-multiplatform.

mazunin-v-jb avatar mazunin-v-jb commented on September 26, 2024

@chrisjenx many thanks!
I haven't reproduced the crash, but the memory warning was received many times, and memory consumption is very weird. We'll look at it

from compose-multiplatform.

chrisjenx avatar chrisjenx commented on September 26, 2024

@mazunin-v-jb I will give 1.6.11 ago, I'm wondering if this was the cause of the OOM JetBrains/compose-multiplatform-core#1355

from compose-multiplatform.

chrisjenx avatar chrisjenx commented on September 26, 2024

Initial testing, looks like JetBrains/compose-multiplatform-core#1390 fixed it, just running profiling now.

from compose-multiplatform.

chrisjenx avatar chrisjenx commented on September 26, 2024

So far looks like peak memory usage is 90mb on the demo project, no more OOM crashes, still churning memory but at least not exploding.
Will test on my main project then close if doesn't crash there.

from compose-multiplatform.

okushnikov avatar okushnikov commented on September 26, 2024

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

from compose-multiplatform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.