Consider collapsing adjacent panel borders about lazygit HOT 3 CLOSED

There are a few challenges with implementing this. As you say, overlapping panels requires heavy box drawing characters rather than highlighting, which means if we still want to highlight the border of the selected panel via bright white, there would be a slight spill into the adjacent panel. Looking at my screen, just using the heavy box characters alone doesn't make the focus of the current panel very obvious, so there would need to be a tradeoff there.

Secondly if you want to highlight e.g. the files panel, you'd need it to know about the branches panel below, and only highlight those edges outside of the 'Branches' heading, which would require some refactoring in gocui (the UI library this repo uses). Likewise if you want to highlight the Diff panel, which happens during merge conflict stuff, you'd need know where the corners of the side panels are so that you can draw the correct box characters

Nonetheless I've implemented some of the code. If you set var OverlappingEdges = true in lazygit/gui.go you'll get overlapping edges but with the abovementioned issues. I'm not sure whether I want to make it a configurable user option now or wait till there's proper highlighting that addresses the above issues. Happy to take suggestions :)

from lazygit.

Yep, that looks to be a serious improvement to me, issues notwithstanding.

It does, however, remind me of one thing I forgot to suggest: removing the outer edge borders (left, right and bottom, that is; top can’t be removed so readily).

I’ve made exactly this style of suggestion on a couple of other projects, you’re the first to seriously experiment with it. 🥇! But you have a trickier time of it than the other projects, because you actually have to indicate panel focus in some way, whereas other projects I’ve suggested it on didn’t have to worry about that. Using reverse on the title of the active pane may be reasonable.

from lazygit.

Closing this ticket, may revisit in the future :)

from lazygit.