Keybindings for editors about lazygit HOT 4 CLOSED

I'm assuming the same is true of other non-OSX platforms

This isn't the case; open(1) is inherited from NextStep and not present on non-macOS platforms. The conventional behaviour is to check $VISUAL et cetera as @d6e suggests, falling back to vi if none of those variables are defined.

from lazygit.

Currently 'o: open' calls the open bash command which opens whatever editor would have opened if the file was opened in finder (I'm assuming the same is true of other non-OSX platforms). I'm having a look at man open and I can pass a -t flag to use the default text editor, but I like the idea of opening the editor that suits the filetype regardless of what the default is. @d6e Do you reckon it should just use $EDITOR or do it based on filetype, or should there be a command for each?

from lazygit.

@srstevenson thanks for the clarification. I've realised that opening vi isn't as clear cut as I thought it would be, because unlike standalone applications like sublime or vscode, it needs to be called as a subprocess in the current terminal. I've put up a PR (#18) that kind of does the job but after focus is returned to the app it gets very glitchy. Any contributions here would be greatly appreciated :)

from lazygit.

@d6e @srstevenson This behaviour is now implemented. The app tries the git editor, then VISUAL, then EDITOR, then vi. This is for the 'e' keybinding which is to edit the file.

from lazygit.