[BUG] New file "editions/tw5.com/tiddlers/Selection Constructors: Conditional.tid" breaks git checkout in Windows because it is an invalid file name about tiddlywiki5 HOT 9 CLOSED

Thanks @asampal @saqimtiaz – the multi-wiki-support branch should be fixed now.

from tiddlywiki5.

@Jermolene -- This is an important one, since it prevents checkout on Windows. There is an invalid character in the filename -- IMO the : is the culprit

from tiddlywiki5.

This is a by product of the PR maker not being able to generate valid filenames.

Ideally we would want to reproduce the same behaviour as on node.js via filter expressions/functions that we can use in the PR maker edition.

@pmario would you possibly have the time to look at this?

from tiddlywiki5.

@JulioCantarero -- This one seems to be fixed - so you can close it

from tiddlywiki5.

Thanks @JulioCantarero @saqimtiaz

from tiddlywiki5.

Still happening for me under windows. I've deleted my local multiwiki branch from earlier, and tried to re-check it out, but get the reported error when doing so.

from tiddlywiki5.

@asampal is the problem occurring only only the mws branch, or on master as well?

from tiddlywiki5.

The master branch is fine, @saqimtiaz

from tiddlywiki5.

@Jermolene I think you need to merge the changes from the master branch to the mws branch.

from tiddlywiki5.