Comments (3)
Did you mean:
{
"name": {
"BD": "Dhaka",
"BE": "Brussels",
...
},
"capital": {
"BD": "Dhaka",
"BE": "Brussels",
...
},
...
}
Your example uses an array, with object syntax and that will not work. I believe you meant to use an object instead of an array of objects. If I am reading that correctly, I agree that would be a little easier to access and reason about.
Thank you for the suggestion. I'll look forward to your PR.
from sampleapis.
I like this conversation but @jermbo @jldorta
The question is would you want to access the object as:
CountryReply.us.population
or
CountryReply.population.us
that would dictate how we rearrange this api.
from sampleapis.
Good point. I understand why the original code was split into different categories, that was a decision by the original contributor.
How I would have done this would be something like this:
{
"countries": {
"US": {
"capital": "DC",
"population": 1,
"currency": "UDS",
...
},
...
}
}
or
{
"countries": [
{
"abbreviation": "US",
"capital": "DC",
"population": 1,
"currency": "UDS",
...
},
...
]
}
The difference is an object with the abbreviations as the key, versus an array of objects. They will all send the same data, just packaged together.
The pro of this approach is all the data you need is right there and you can shape the graphQL to the actual data you need.
The con is.... less endpoints?
from sampleapis.
Related Issues (20)
- Basic Type Safety for EndPoints
- API Data Reset
- Docs - What is REST HOT 4
- Docs - What is GraphQL HOT 3
- Docs - How APIs Work HOT 5
- Ensure API list is dynamically generated
- Update Contribution Documents
- Certificate has expired HOT 2
- New Coffees HOT 1
- Site down HOT 4
- Wrong data API coffee HOT 3
- API response includes errant name and rating avg values HOT 1
- website is having issues HOT 1
- APIs are returning 429 "Too many requests" error HOT 2
- Website is having issues HOT 3
- Inappropriate image URL in beers API HOT 1
- Fix API 502 Bad Gateway HOT 2
- API List > Categories HOT 1
- 502 when hitting api.sampleapis.com HOT 1
- Presidents API image for John Adams is outdated and missing HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sampleapis.