Code Monkey home page Code Monkey logo

Comments (11)

jeremyfix avatar jeremyfix commented on July 18, 2024

Thank you for the bug report;

I suppose, but correct me if I'm wrong, this is happening when :

  • you run dcejs on MacOs
  • you run a "Start VNC"

If this is correct, I have to check the reason but this bug should only occur on MacOS users for which we use xml2json which is the dependency complaining for the missing node-expat module.

I have to check why the xml2json module is not installing its dependency ; Otherwise I could also drop the feature we implement with xml2json.

Basically , for Mac users, I'm using this xml2json to look for the vncviewer so as to provide a direct accessor to the vnc viewer. It is not easy for me to test on MacOS ; However, I'm wondering if this was working at all for Mac users (that may push the balance toward removing the feature if this is useless);

With the previous working version of dcejs, running VNC, did you notice a clickable blue link on the VNC url ? As on the screenshot below ? That link is expected to be clickable. That was expected at least :) Was it the case ?

image

from dcejs.

space192 avatar space192 commented on July 18, 2024

no the crash happens the moment I start the application

Enregistrement.de.l.ecran.2023-12-14.a.10.26.41.mov

previous versions were working fine I had the blue link on your screenshot, and xml2json was already installed on my mac

from dcejs.

jeremyfix avatar jeremyfix commented on July 18, 2024

Ok, right, this makes sense, this is at import time ; So it makes sense it crashes at startup ;

I will check If I keep or not this feature on MacOS or if I can identify which the dependency behind xml2json is missing.

from dcejs.

jeremyfix avatar jeremyfix commented on July 18, 2024

Indeed there is a build issue on the MacOS platform

https://github.com/jeremyfix/dcejs/actions/runs/7184760935/job/19566583579#step:4:26

from dcejs.

jeremyfix avatar jeremyfix commented on July 18, 2024

However, the upstream package ,xml2json (https://github.com/buglabs/node-xml2json) is deprecated, and itself depends on deprecated packages ; I will certainly drop the feature and publish a new release soon.

from dcejs.

space192 avatar space192 commented on July 18, 2024

love how the logs says that info This module is OPTIONAL, you can safely ignore this error 😅

from dcejs.

jeremyfix avatar jeremyfix commented on July 18, 2024

@space192 would you mind giving a try to this release ? https://github.com/jeremyfix/dcejs/releases/tag/v1.9.5

It is expected to run with the removal of the "blue clickable link" feature.

from dcejs.

space192 avatar space192 commented on July 18, 2024

the app starts now ! And during the lab i've tried to launch vscode server with and without reservation.
it works without any reservation, but doesn't when I have a reservation code !

from dcejs.

jeremyfix avatar jeremyfix commented on July 18, 2024

Humm ... there should be no reason to have a difference between "with reservation" and "without reservation";

I just gave a try on Ubuntu . In both cases, running VSCode server works;

One thing I noticed, is that you may need to wait a bit before being able to contact the vscode server through the ssh tunnel adress indicated by dcejs ; Like 1 or 2 minutes; Actually, dcejs starts vscode server in background and immediately setup the ssh tunnel ; This implies the ssh tunnel is certainly established before vscode server starts.

Probably the simplest would be to debug that together; I will contact you.

from dcejs.

JasonMendoza2008 avatar JasonMendoza2008 commented on July 18, 2024

FYI The "with reservation" mode works for the students that had problems with the previous versions (same error, fixed by using the pre-release 1.9.5).

from dcejs.

jeremyfix avatar jeremyfix commented on July 18, 2024

Thanks for the feedback , I will release the pre-release and close the issue;

from dcejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.