Add some basic tests about hacktoberfest-checker HOT 9 CLOSED

eslint for backend code would be good. would be able to enforce 'use strict'; and similar rule
i would recommend the airbnb eslint config as a base
if you use eslint you could aslo then use eslint handlebars

from hacktoberfest-checker.

I think both have their value. For me it would make sense to do both.

from hacktoberfest-checker.

@butlerx I think you commented #108 not this one.

from hacktoberfest-checker.

What sort of tests did you have in mind? Unit tests or end to end tests with mocked Github responses?

from hacktoberfest-checker.

I'd gladly add unit tests for the JS part.

from hacktoberfest-checker.

Sorry for delayed response, yeah open to either. End to end would make most sense to me? As currently there isn't really much to unit test?

from hacktoberfest-checker.

@gagyibenedek would welcome a PR if you fancy :)

from hacktoberfest-checker.

will do! :)

from hacktoberfest-checker.

Closing in prep for 2018 rewrite.

from hacktoberfest-checker.