Prefix/postfix increment operators broken within closures about groovy-sandbox HOT 2 CLOSED

I've added my attempted fix for the problem as a pull request, but it could definitely use some review. I added test cases to confirm that this specific problem is solved, but I am not necessarily confident that I have handled all of the edge cases (for example, that incrementing or decrementing other types of objects will always be handled correctly).

I arrived at this particular solution after looking at the difference in the MethodCallExpressions constructed by "i.next()" (which worked) and "++i" (which failed), and by realizing that the former had implicitThis=false while the other had implicitThis=true.

from groovy-sandbox.

I tried to reproduce this today, and could not. The following test passes when added to SandboxTransformerTest:

@Test public void prefixOpInClosure() throws Exception {
    assertIntercept(
            "def myClosure = {\n" +
            "    def i=0\n" +
            "    ++i\n" +
            "}\n" +
            "myClosure()",
            1,
            "Script1$_run_closure1.call()", "Integer.next()");
}

Maybe it was accidentally fixed by 18c9f74? I am going to go ahead and close this issue, but feel free to reopen it if I am mistaken.

from groovy-sandbox.