Docker slave empty DNS about docker-plugin HOT 4 CLOSED

It's being set, but for some reason the latest version of Docker seems to ignore this.
It was working on 0.7.x, but isn't on 0.10.x.

You can see the DNS being sent in the JSON that's logged to the console

I worked around in the short term by adding a --dns entry into DOCKER_OPTS

from docker-plugin.

Docker has changed, this is now part of HostConfig.
Made change to jDocker and added fix here, is in -master / next release.

from docker-plugin.

I am still having trouble where leaving the field blank gives unexpected defaults in 0.3.5
HostConfig{..., "Dns": null} results in the container inheriting the hosts settings, which for me is desirable as the network restricts what can be used for dns.

However, docker-plugin seems to at a minimum send "Dns": [""] which gives the problem described by OP. I think null is the more reasonable default, and if the user does not want to have dns they can put a space or random ip in the box.

from docker-plugin.

So there's 2 DNS settings

1. the Container configuration
2. the Host configuration (used to spin up the container).

In the docker API, (1) now seems to be deprecated. (2) is new, and therefore not supported on all docker versions. For the sakes of backwards compatibility, the plugin sets both.

Now that docker has apparently officially gone 1.0, we should probably move to remove (1) altogether.

from docker-plugin.