Comments (2)
Thanks for bringing this to our attention? Would you care to make a pull request for one or both solutions you suggest?
from vulture.
Copying my comment from the PR:
I read up on this issue again and found the reason why things are configured the way they are: with pass_filenames: true pre-commit will only check modified files and therefore produce many false positives (see #244). While researching this, I found pre-commit run --all-files
but I think the current solution of requiring the user to specify the files leads to better results.
I don't see a better solution than the status quo, so I'm closing this PR. But we can definitely reopen it when we find a better solution.
from vulture.
Related Issues (20)
- vulture does not detect code usage by `case` clauses in pattern matching HOT 3
- Mark deleted variables as used HOT 3
- AttributeError when parsing a decorator HOT 5
- Whitelist parameter of specific function HOT 2
- Pydantic false positive HOT 1
- Read config from `setup.cfg` HOT 1
- Feature request: not throw "unused variable" for __exit__ HOT 1
- [feat] Support setup.cfg configuration file HOT 2
- [feat] Support premade-whitelist HOT 1
- Listing uncalled functions across multiple projects/repositories. HOT 1
- Allow unreachable trailing `yield`, to make an abstract generator method HOT 5
- UnicodeEncodeError in core.py HOT 3
- Ignore subclasses HOT 1
- Add argument to filter for unused function, variable or class HOT 4
- False positive when enum is used in iteration HOT 7
- False positives on enum `_name_` and `_value_` attributes HOT 2
- False negatives when function/method/attribute name is in one of the whitelists/*_whitelist.py files. HOT 1
- Dedicated exit code for "Dead code found" HOT 2
- Wrong processing of typing.Protocol HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vulture.