Add a permission setting to optionally allow popups from websites about vieb HOT 5 CLOSED

I don't think that I use any site that uses popups to confirm or show any relevant information. As such, I have personally always considered the lack of popup support more a feature than a bug. I'm curious as to which site this might be and what your view on popups are, given that you clearly have more use for them than I have.

On the other hand, you could also ask the website to stop using popups to confirm a password reset. Other browsers such as Firefox have popups blocked by default, which to me is a good thing, although it would also be great if Vieb offered the same level of customization for the popup blocker as Firefox. The difference here being that Vieb isn't explicitly blocking them, but it's more of a default for Electron webviews. I'll just check if this webview flag can be changed for existing webviews, if so, we could think of adding settings related to popups.

from vieb.

I'll do some research on this and try to understand it better. Thanks @Jelmerro

from vieb.

I ran into this ticket again, and after some experimentation I noticed that there is no way to allow popups while also running Vieb's code in the popup window. It just opens the page itself in a new window, without any options or configuration to change this. This means that none of Vieb's features will be able to run in a popup window.

It makes more and more sense to just keep redirecting these popups to new tabs. I keep seeing this as the recommended option everywhere when they mention anything about popups, including the window.open MDN page and the previously mentioned sources.

It's for the reasons above that Vieb will not be receiving a popup permission or allow any kind of popups in the near future. I'll close this ticket as wont fix. For those that for some reason still want to enable popups in Vieb, you'll have to download the source and make your own Vieb build which permanently allows popups by adding: webview.setAttribute("allowpopups", "") below this line.

from vieb.

I hate to bring some bad news regarding this ticket, but I can't exactly reproduce the popup behavior with some of the sites that do apparently use popups (in Firefox). My experience has actually been that those will open in a new tab without issue. In addition to that, it appears that webviews do not allow this "allowpopups" flag to be changed after the webview was created. As a result, I don't think it's possible to make this a setting without requiring a restart, or at the very least require tabs to be re-opened. Having said that, I don't think I'll be making in effort to work on this myself. If you understand Javascript you can make your own Vieb build which permanently allows popups by going to this line and adding this: webview.setAttribute("allowpopups", ""). Keep in mind that this will permanently allow popups for every single page you visit, which might not be what you want, which is exactly why I don't see this making it's way into Vieb anytime soon. Though if anyone knows a better way to integrate the popups into Vieb's permission system, go ahead.

from vieb.

Upon inspecting the official Electron security docs, I noticed that they also recommend to leave popups disabled. Although they go into little detail as to why, I suspect that it's similar to my previous reasons listed. With more and more reasons to keep the popups blocked, I would recommend to get in touch with website owners that still use them, and to keep blocking them with Vieb. I'll update the ticket title to better reflect the changes needed, which would be a permission setting to OPTIONALLY allow popups.

from vieb.