Crash when removing endpoint about membrane_rtc_engine HOT 7 CLOSED

Hey @Karolk99, was it fixed as of e407f06?

from membrane_rtc_engine.

The issue persists on master @Karolk99.

from membrane_rtc_engine.

What has to be done, is to implement handle_child_pad_removed for input pads of WebRTC.Endpoint in RTC.Engine

from membrane_rtc_engine.

Yes this is what I've done in our fork. PR coming!

from membrane_rtc_engine.

Even though that callback is marked as optional, hence I would expect the fix to be implemented in membrane_core 😉

from membrane_rtc_engine.

Released as 0.15.1 🙂

from membrane_rtc_engine.

Even though that callback is marked as optional, hence I would expect the fix to be implemented in membrane_core 😉

Callback handle_child_pad_removed/4 is optional because you can write a module, that implements @behaviour Membrane.Bin or Membrane.Pipeline without implementing handle_child_pad_removed/4 and it will compile without a warning. When you mark callback as optional in Elixir behaviour, it means, that you might, but you are not forced to implement it in the module that implements your behaviour.

We have improved the message in the error raising on try to call not implemented handle_child_pad_removed/4 in the upcoming release, but we won't make this callback not optional.

from membrane_rtc_engine.