Code Monkey home page Code Monkey logo

Comments (8)

jellyfin-bot avatar jellyfin-bot commented on June 12, 2024

Hi, it seems like your issue report has the following item(s) that need to be addressed:

  • This bug report was not filed using the issue template.

This is an automated message, currently under testing. Please file an issue here if you encounter any problems.

from jellyfin.

gnattu avatar gnattu commented on June 12, 2024

This is working as intended. If you have security concerns auto discovery should not be used in the first place.

from jellyfin.

gnattu avatar gnattu commented on June 12, 2024

If you really want to override the announced url, you need to write the full url(like http://example.com) and set it as JELLYFIN_PublishedServerUrl environment variable, only this env variable will be picked up by auto discovery.

from jellyfin.

selfhoster1312 avatar selfhoster1312 commented on June 12, 2024

Thanks for the quick answer. So from what i can read there is also a CLI flag. But there is no network.xml setting for this yet? What are KnownProxies and PublishedServerUriBySubnet for then?

I can't seem to find the complete documentation for the settings.

from jellyfin.

gnattu avatar gnattu commented on June 12, 2024

We usually don't put such super advanced config into xml, and those hidden options have no documentation because we don't expect most users to ever alter them.

from jellyfin.

Shadowghost avatar Shadowghost commented on June 12, 2024

Just as an FYI: what you have in your config XML is wrong.
The proxy stanza should include the upstream proxy IPs/subnets and the override should be subnet=override, e.g. 127.0.01/8=https://domain.tld

If you have local subnets and proxy properly configured you can also use external, internal and all instead of a subnet.

from jellyfin.

selfhoster1312 avatar selfhoster1312 commented on June 12, 2024

Thanks for your time! I'm gonna close the issue because the workaround is "documented" here.

However, i can't voice enough that documenting settings (or lack thereof) is very important. I just spent a lot of time looking through code because some settings have been deprecated/renamed and this was not in the release notes on the blog. I also could not find a migration guide, CHANGELOG or anything of the sort (maybe i missed it?)

we don't expect most users to ever alter them

It's not just admins who can be confused. It's also maintainers trying to integrate Jellyfin into a selfhosted ecosystem like Yunohost who need to come up with config templates.

Just as an FYI: what you have in your config XML is wrong

Thanks for the example. Just for clarification what is KnownProxies used for if not for discovery?

from jellyfin.

Shadowghost avatar Shadowghost commented on June 12, 2024

If you don't set Know proxies, Jellyfin uses the IP of the proxy and not the one from the proxy header to decide if it's an internal/external request. This has an impact on e.g. remote access checks, bandwidth enforcement and similar

from jellyfin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.