Code Monkey home page Code Monkey logo

Comments (4)

h1dden-da3m0n avatar h1dden-da3m0n commented on July 18, 2024

This seems to be handled by #67

from jellyfin-plugin-opensubtitles.

MBR-0001 avatar MBR-0001 commented on July 18, 2024

Yes, that pull request basically ensures this doesn't happen, but the issue is that I couldn't get the plugin to produce the query string from above, everything I tried got me this

episode_number=1&languages=&moviehash=5716a7688381082d&moviehash_match=only&query=marvel%27s+the+punisher&season_number=1&type=episode

(notice how there's an & after the =), it also may be worth mentioning that the plugin always sets the page param (which seems to be missing in that example).

Are you sure this is coming from this plugin? @opensubtitles

from jellyfin-plugin-opensubtitles.

opensubtitles avatar opensubtitles commented on July 18, 2024

you are right, it was caused on our side, we are using varnish to make some URL handling (sorting params, url to lower and so on), so it should be fixed now. The problematic URL was for example
https://api.opensubtitles.com/api/v1/subtitles?episode_number=30&languages=id&moviehash=da4dfeb153fc0693&moviehash_match=only&query=Whose+Line+Is+It+Anyway%3f+(US)&season_number=2&type=episode&page=0

please throw some URLs and check their redirect, for example page=0 is not really need there, params should be sorted and lowercase... so we make redirect. Without redirection you will get data faster...

from jellyfin-plugin-opensubtitles.

MBR-0001 avatar MBR-0001 commented on July 18, 2024

Yeah I noticed the redirects just now, I'll fix those. It also looks like the search endpoint has been changed (again?), I'll continue about that at https://forum.opensubtitles.org/viewtopic.php?f=8&t=17592 since it is not really related to this issue

from jellyfin-plugin-opensubtitles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.