Code Monkey home page Code Monkey logo

Comments (7)

hawken93 avatar hawken93 commented on July 18, 2024 3

After reading this I still stand by using Jellyfin v10. Major version and even program name can be read from the core program to be robust against version changes and even rebranding, the goal being to write code that lasts a long time :)

from jellyfin-plugin-opensubtitles.

hawken93 avatar hawken93 commented on July 18, 2024

Isn't it better to go with jellyfin v10, the smaller version numbers shouldn't matter that much and it has to try tracking the main program.. Maybe the core can provide the plugins with an appropriate user agent? :)

from jellyfin-plugin-opensubtitles.

nvllsvm avatar nvllsvm commented on July 18, 2024

Can we register a User-Agent per RFC 2616? The value Jellyfin/10.2 would be more appropriate.

from jellyfin-plugin-opensubtitles.

anthonylavado avatar anthonylavado commented on July 18, 2024

It’s not a useragent in the traditional sense. This is an OpenSubtitles required construct, it’s how they identify that we are an authorized program.

They require it to be in the format AppName vXY.Z, where leading zeroes can be omitted if desired, and the Z can be removed if desired.

from jellyfin-plugin-opensubtitles.

anthonylavado avatar anthonylavado commented on July 18, 2024

See here for details: http://trac.opensubtitles.org/projects/opensubtitles/wiki/DevReadFirst

from jellyfin-plugin-opensubtitles.

anthonylavado avatar anthonylavado commented on July 18, 2024

I suppose like Emby before us, we could omit version entirely.

from jellyfin-plugin-opensubtitles.

anthonylavado avatar anthonylavado commented on July 18, 2024

@hawken93 That’s fine. It sounds good to me.

from jellyfin-plugin-opensubtitles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.