No titlebars on Gnome Wayland about jellyfin-media-player HOT 16 CLOSED

Wow I usually don't like to raise opinions on these things but that's really unfriendly to application developers. No other platform does this. Naturally anyone is free to PR something to resolve this as long as it doesn't affect platforms that draw decorations normally.

from jellyfin-media-player.

Again, I think Qt defaults to X11 (at least on GNOME), but you could verify that.

The flatpak just defaults it to Wayland. I do not believe it has other meaningful changes.

from jellyfin-media-player.

Nice. If this issue pops up again please comment.

from jellyfin-media-player.

I'm actually seeing decorations on my side running it from the .desktop file shipping with this application in the focal .deb package. Note in the terminal window that I'm running GNOME in a wayland session (though I can't vouch that the program is running as a Wayland app). The Qt Wayland platform plugin also appears to be supporting a fallback UI from as far back as this blog post from 2018:

https://www.qt.io/blog/2018/12/14/whats-new-wayland-platform-plugin-qt-5-12

from jellyfin-media-player.

Did you install with the Flatpak? The Flatpak doesn't give titlebars for me but the AUR package does.

from jellyfin-media-player.

I'm using the most recent SDK with Flatpak, but I have not even the slightest idea what might be happening.

from jellyfin-media-player.

You can use xprop and try clicking on the window, if it doesn't show info after clicking on the window that means it's running on native wayland. You can also launch the app with QT_QPA_PLATFORM=wayland to force wayland, I've seen some QT apps fall back to xwayland when it's not specified. I've only tried the flatpak version on gnome (and also, flatpak forces wayland due to the x11-fallback permission being set, so without altering the permissions the app can't fall back to xwayland even if it wants to).

from jellyfin-media-player.

So we cant have full screen when using the flatpak version in wayland?

from jellyfin-media-player.

The docs weren't very helpful on this so I filed a bug upstream: flatpak/flatpak-docs#250

from jellyfin-media-player.

Just to be clear about this behavior:

• Wayland, the protocol, doesn't specify that compositors render window decorations, that was never the intention
  • There are optional, and relatively new, extensions to request the compositor render window decorations
    • GNOME does not and will not, at least in the short term, support this.
    • I'm not sure if Qt uses this or not already.
• Flatpak isn't relevant here, except for the fact it defaults to the Wayland backend, when Qt normally defaults to X11
  • This can be changed in the package if so desired, at least for now

The solution is likely just the application rendering its own titlebar, I'm not familiar with Qt but I assume thats just another widget?

from jellyfin-media-player.

• Flatpak isn't relevant here, except for the fact it defaults to the Wayland backend, when Qt normally defaults to X11
  • This can be changed in the package if so desired, at least for now

@TingPing, It seems strange to suggest the use of X11 to work around the lack of SSD's in GNOME Wayland.
Perhaps there's a middle ground here that wouldn't meaningfully impact performance of JMP, while also requiring
the least implementation work on Jellyfin's part. After all, window decorations have been provided by the WM for well over 50 years now.

For the record, JMP also works totally fine on KDE, Sway, etc.: it's got the title bar, window decorations, the works. Would there maybe be something GNOME-specific to apply here as a patch?

from jellyfin-media-player.

You implement CSD. That is all you can do. Again Qt surely has wigetry for this. Just need a close button really if a titlebar isn't important.

from jellyfin-media-player.

Qt supports client side decorations for sure.

See here:
https://wiki.archlinux.org/title/Uniform_look_for_Qt_and_GTK_applications#Qt_apps_run_on_GNOME_Wayland_have_a_non-matching_window_decoration_look,_even_after_setting_a_Qt_theme

Can even get it to match adwaita's title bar if you want.

For some reason the QT in flatpak doesn't do this at all. AUR package obeys the system QT ofc so it works.

from jellyfin-media-player.

Another comment from someone was to use sudo flatpak override --nosocket=wayland com.github.iwalton3.jellyfin-media-player command. Worked for me

from jellyfin-media-player.

I've simply disabled Wayland support on the flathub package. If upstream ever wants to support it let me know to re-enable it.

from jellyfin-media-player.

I think this issue can be closed.
After updating the Jellyfin Media Player Flatpak yesterday, I noticed that I now get a titlebar while running natively under Gnome Wayland (not XWayland).

from jellyfin-media-player.