Comments (3)
qrush
commented on May 12, 2024
I think xml_escape should be deprecated in favor of using cgi_escape, and cgi_escape should be renamed to simply escape. I don't see any reason why we shouldn't use this for all escaping needs. Any thoughts?
from jekyll.
vilcans
commented on May 12, 2024
I think we need both. xml_escape for escaping strings that are to be inserted into HTML or XML and that may contain <, > or &. cgi_escape for strings that goes into URLs and may contain space, #, % and other special characters.
from jekyll.
qrush
commented on May 12, 2024
Ah, I see the difference now. I merged your patch in and changed xml_escape to use CGI.escapeHTML. Thanks!
from jekyll.
Related Issues (20)
- [Bug]: "undefined method `yaml_file?' for #<Jekyll::page @name="404.md"> in /_layouts/single/html HOT 16
- I initially had logic that was a lot more tolerant of `s`s. And then I ran into the [🥔 🐛 - potato bug](https://github.com/check-spelling/check-spelling/releases/tag/0.0.17-alpha) -- namely the plural of `potato` is not `potatos`. It was so embarrassing, since I learned the proper spelling in elementary school. It was also a big deal as a [Vice President suggested `potatoe` to a student](https://abcnews.go.com/Politics/video/june-15-1992-dan-quayle-misspells-potato-48017343).
- [Docs]:
- [Bug]: Unable to build website
- [Bug]: `permalink_ext': undefined method `end_with?' for {}:Hash
- [Bug]: error running "bundle exec jekyll s" HOT 4
- [Bug]: related_posts prefers longer articles
- [Bug]: Can't serve website due to sass-embedded version HOT 5
- [Bug]: Jekyll release v3.9.5 is missing from GitHub, only exists in ruby gems HOT 1
- feat:
- [Bug]: Obsolete nodeJS version HOT 1
- [Bug]: Empty include parameter when assign a forloop attribute to it.
- Unquoted language code "no" not recognized in _config.yml HOT 1
- [Bug]: pipe character to single row table priority unexpectedly high
- feat: Adding relative path to current URL support HOT 2
- [Bug]: Livereload don't work for project initiated with --blank flag HOT 1
- feat: XMPP: Post to PubSub
- [Bug]: jekyll changes filenames when copying files to _site on build
- feat: can you make a grapgic fenweator for instagram and youtube with jekyll with a javaacript or a webrtc based json , or even an encrypted json to a rest blob
- [Bug]: exclude broken for md files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jekyll.