Be able to control prefix even if on GitHub Pages about jekyll-redirect-from HOT 8 CLOSED

@dentarg A mistake – sorry!

from jekyll-redirect-from.

Is there any reason not to default to site.url, if set, and then fall back to site.github.url?

from jekyll-redirect-from.

We use GitHub Pages, but we don't use the CNAME file, because we have our own proxy and cache before GitHub Pages.

The use case for this is that we want to avoid SSL errors if someone tries HTTPS and our custom domain name.

from jekyll-redirect-from.

I'm kinda torn on this. One thing to do in the meantime is to just write a layout that uses our redirect HTML and hook it in with some front matter variables and write the redirection pages yourself.

/cc @benbalter

from jekyll-redirect-from.

@benbalter That would be just fine.

from jekyll-redirect-from.

@parkr @benbalter like this?

$ git diff
diff --git a/lib/jekyll-redirect-from/redirector.rb b/lib/jekyll-redirect-from/redirector.rb
index 40db8c3..91b7067 100644
--- a/lib/jekyll-redirect-from/redirector.rb
+++ b/lib/jekyll-redirect-from/redirector.rb
@@ -69,7 +69,11 @@ module JekyllRedirectFrom
     end

     def redirect_prefix(site)
-      config_github_url(site) || config_baseurl(site) || ""
+      config_url(site) || config_github_url(site) || config_baseurl(site) || ""
+    end
+
+    def config_url(site)
+      site.config.fetch('url', nil)
     end

     def config_github_url(site)

and adjustment of specs

from jekyll-redirect-from.

👍

from jekyll-redirect-from.

Hmm... what's the reason for closing this?

from jekyll-redirect-from.