Code Monkey home page Code Monkey logo

Comments (6)

claudiopro avatar claudiopro commented on June 14, 2024 1

+1 to customize the template for the redirect page

from jekyll-redirect-from.

pathawks avatar pathawks commented on June 14, 2024

There is no reason to include a favicon <link> tag on a redirect page. The page is not meant to be bookmarked, or serve as a destination. The only purpose of the page is to redirect the visitor to the proper URI as quickly as possible.

As has been discussed before, linters should serve humans rather than the other way around.

Is there an option to disable the check_favicon option?

from jekyll-redirect-from.

eksperimental avatar eksperimental commented on June 14, 2024

yes, i was aware of the discussion, but I think the reasons giving there did not contemplate the case where we need to modify those file to pass that sort of validation.
I am passing the check-favicon argument, because I want htmlproof to check for that in those pages, but I want to pass that validation. I think it will be easier if we can do whatever we please with that page. or in the future X validator complains about the markup, we can still tweak it.

Yes, maybe htmlproof should check if the page is a redirect, and then forget about favicon,
but again, htmlproof is promoted by jekyll website, and it's mentioned to run with the favincon option.

from jekyll-redirect-from.

jekyllbot avatar jekyllbot commented on June 14, 2024

This issue has been automatically marked as stale because it has not been commented on for at least
three months.

The resources of the Jekyll team are limited, and so we are asking for your help.

If you can still reproduce this error on the 3.1-stable or master branch,
please reply with all of the information you have about it in order to keep the issue open.

If this is a feature request, please consider building it first as a plugin. Jekyll 3 introduced
hooks which provide convenient access points throughout
the Jekyll build pipeline whereby most needs can be fulfilled. If this is something that cannot be
built as a plugin, then please provide more information about why in order to keep this issue open.

Thank you for all your contributions.

from jekyll-redirect-from.

lifeisfoo avatar lifeisfoo commented on June 14, 2024

Customization of the redirect page could be useful for localization purposes.

from jekyll-redirect-from.

parkr avatar parkr commented on June 14, 2024

@lifeisfoo This is a duplicate of #55.

from jekyll-redirect-from.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.