Code Monkey home page Code Monkey logo

Comments (9)

ojame avatar ojame commented on July 19, 2024 1

We're using ES6's computed values (Babel, of course):

{
   [styles.Bar]: true,
   [this.props.className]: this.props.className,
}

from classnames.

dcousens avatar dcousens commented on July 19, 2024

@oleronning can you give an example of how you think this would work?

from classnames.

oleronning avatar oleronning commented on July 19, 2024

@dcousens based on your current implementation, this may not be straigh forward, but one possible solution is to pass an object as a parameter like so:

{
  'substrings': ['alert-', alert_type],
  'build_string': typeof(alert_type) !== 'undefined'
}

This was my first thoughts, but I'm not suprised if there is an more elegant/effective way of doing it.

Thanks!

from classnames.

dcousens avatar dcousens commented on July 19, 2024

@oleronning and the resultant string would be?

from classnames.

oleronning avatar oleronning commented on July 19, 2024

@dcousens if var alert_type = 'warning' the resultant string would be alert-warning

from classnames.

dcousens avatar dcousens commented on July 19, 2024

Why wouldn't you just use { "alert-warning": typeof(alert_type) !== 'undefined' }.

from classnames.

oleronning avatar oleronning commented on July 19, 2024

Because alert_type is passed to my method as an argument, and might just as well be danger or success

from classnames.

oleronning avatar oleronning commented on July 19, 2024

@ojame Sweet! Thanks a lot!

from classnames.

dcousens avatar dcousens commented on July 19, 2024

@ojame of course, @oleronning this is definitely the way to do this.
Lets not over-complicate this module with what is essentially a language hitch.

Thanks @ojame

from classnames.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.