Broke if you both use AMD and commonjs on the same page about classnames HOT 11 CLOSED

Can't we all just get along.

@JedWatson can we just export like normal, but then just recommend people to use a wrapper that does it properly for them?
In the end, this is a node package.

IMHO, anyway.

from classnames.

@kevinsimper can you please clarify what you mean by "broke"? and how it should behave in that case?

Looks to me like fixing this might be as simple as putting this condition first:

if (typeof module !== 'undefined' && module.exports)

from classnames.

I'm also curious about what broke means here, this is just a very common wrapper, used everywhere. And I'm also curious about the scenario of having both amd and commonjs on the same page.

Cheers!

from classnames.

If you are on a webpage where you both have requirejs and use browserify, then the module.exports will never run and therefore the browserify version will not work.

Because both amd and module can be defined on the same page. So the else if prohibites the use of both.

I can agree that it is stupid to use both on the same page, but sometimes its something you can not decide.

from classnames.

@kevinsimper can you confirm whether my proposed change would work, or would you expect it to expose both CommonJS and AMD? A PR that you've confirmed meets your requirements would be welcome.

from classnames.

I'm seeing this issue when using react-boostrap, which includes classnames as a dependency. I'm also using browserify and babelify to bundle.

Uncaught Error: Mismatched anonymous define() module: function () {
return classNames;
}


This is fixed by flipping the conditions, as @JedWatson suggests:

from classnames.

I ran into the same problem after #41 merged (v2.1.3), but it works in v2.1.2. My use case is using requirejs but I saw classnames always run in module.export at
https://github.com/JedWatson/classnames/blob/master/index.js#L38

therefore, it doesn't execute second AMD statement and return undefined every time.

from classnames.

Sorry, @JedWatson ❤️

from classnames.

@JedWatson is this fixed and published?

from classnames.

I download bower classnames today:

### dedupe.js, start line 88

if (typeof module !== 'undefined' && module.exports) {
        console.log("undefined");
        module.exports = classNames;
    } else if (typeof define === 'function' && typeof define.amd === 'object' && define.amd) {
        // register as 'classnames', consistent with npm package name
        define('classnames', [], function () {
            return classNames;
        });
    } else {
        console.log("window")
        window.classNames = classNames;
    }

made the change suggested by @dcocchia and it worked

if (typeof module !== 'undefined' && module.exports) {
        console.log("undefined");
        module.exports = classNames;
    } else if (typeof define === 'function' && typeof define.amd === 'object' && define.amd) {
        // register as 'classnames', consistent with npm package name
        define(function () {
            return classNames;
        });
    } else {
        console.log("window")
        window.classNames = classNames;
    }

from classnames.

I'm assuming this was resolved, please comment if otherwise.

from classnames.