Comments (3)
Thanks for bringing this up! We try to map types 1:1 into ReScript, so the omission of options wasn't intentional, it probably just wasn't there when these bindings were written. So, yes, we should definitely add it. Sadly, inconsequential additions in javascript can create breaking changes here in ReScript, but not much we can do about it. Would you like to take a stab at it?
from rescript-apollo-client.
@jeddeloh I tried, but it wasn't too successful. The link between 'variables
and 'jsVariables
is not clear to me. I know we serialize 'variables
to 'jsVariables
and we can map 'jsVariables
to 'jsVariables
, but in this case do we need to do conversion from 'jsVariables
to 'variables
, since update
accepts a callback function that is passed to the JS side? There are many types that need to accept another type parameter, so I guess someone more experienced in this codebase would be needed.
from rescript-apollo-client.
The function inside of the module generated by the ppx to do this is Query.parseVariables
. This can either happen in the library or the user can do it, doing the conversion in the library is probably a bit nicer.
from rescript-apollo-client.
Related Issues (20)
- RetryLink and OnError Handling issue HOT 6
- Link headers HOT 2
- EOL for ppx in rescript HOT 3
- Nullable field being discarded from mutation HOT 4
- pollInterval option missing from watchQuery
- Incompatibility/Bug with @apollo/client > 3.5.0 HOT 2
- Runtime error with ApolloClient.Utilities.getOperationDefinition function HOT 3
- @apollo/client 3.5 features HOT 1
- Fetching fragment along with other fields HOT 2
- Support `returnPartialData` option after graphql-ppx adds support
- Support for RefetchQueriesFunction HOT 1
- How do I use the InMemoryCache's FieldMergeFunction? HOT 4
- support to nextjs ? HOT 2
- Getting Jest tests to ignore module
- ErrorLink and RetryLLink examples and/or documentation HOT 6
- Is it possible to remove react and rescript-react as dependencies for this to work? HOT 1
- Support rescript 10 HOT 3
- [Discussion] Convert to using optional records? HOT 1
- subscriptions-transport-ws has been deprecated HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rescript-apollo-client.