Challah::Signup incompatible with ActionController::Parameters in Rails 5 about challah HOT 3 CLOSED

Yeah, that's essentially what I did to fix it. I'm OK with that workaround if you want to keep it that way.

from challah.

Hey @philtr!

I'm not even sure that class is in use anymore within the rest of the code, if it is I can't find it.

We could update the class to accept the params object in here, but I think the better way to do that would be within the controller (so by the time it gets into the Signup object everything is already in a hash.)

Does something like this work in your controller where you're calling signup?

signup  = Challah::Signup.new(params.permit!.to_h)
signup.save

from challah.

Great. I'm happy to add something in if you think it makes sense :)

from challah.