Comments (5)
In my case I wanted to change that behaviour so on top of #7 fix/workaround, I created another branch to have .then behave correctly on piping. Again, propably I could do some cleanup if you consider a pull-request.
from jdeferred.
thanks @mehiel ! I'll be on a roadtrip for a week or 2. i'll take a look in detail once i'm back.
from jdeferred.
@saturnism, have fun and maybe we can elaborate on these things when you'll be back!
from jdeferred.
@mehiel i'm back and i've been researching into this a bit. it seems like done callbacks shouldn't have the ability to reject - because in order to trigger done callback, a resolve was already called and state is already changed?
what do you feel if the exception is handled within the callback itself, or maybe have an unexpected exception callback?
A implementation that looks pretty clean is using then/pipe and returning a new deferred object - this is something that can't be done in current jdeferred implementation, but it seems worthwhile to pursue.
from jdeferred.
see issue #10 for piping. It is closer to what jQuery does.
from jdeferred.
Related Issues (20)
- Thorough check on nullable/non-nullable arguments HOT 7
- DeferredPromise can be simplified by extending DelegatingPromise HOT 1
- Doc points to core for Maven but Android for Gradle
- Configure auto-module on JAR Manifest
- Improve code formatting, compiler warnings and JavaDoc HOT 2
- Is there a need for an AlwaysPipe? HOT 3
- Substantiating return type for promise.then(DoneFilter) and promise.then(DoneFilter, FailFilter) HOT 4
- For JDeferred 2, update artifact and package names HOT 2
- Handle Android Lifecycle HOT 2
- Configure bintray plugin to automatically publish to Maven Central
- Promise.then() is difficult to use with lambdas HOT 5
- Automatically publish README.md to jdeferred.org
- DonePipe cannot be use when() together HOT 2
- await function HOT 3
- it doesn't work under app bundle HOT 1
- Notifications Can Be Lost HOT 2
- add extend serialize for DoneCallback etc
- Migrating from org.jdeferred 1.2.6 to 2.0.0
- Never call done when proguard enforcing HOT 3
- CONTRIBUYENTES HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jdeferred.