Comments (2)
Upon further investigation, I'm now leaning more towards 3.
- Some of the preprocessing we'll need to do to make this work will also be needed to support #573.
- Providing builtin support for this will avoid the need to allocate a
__dict__
per instance, reducing memory usage somewhat and slightly accelerating attribute access - Likewise, handling this ourselves lets us backport the 3.12 fix to avoid usage of an
RLock
per cached property, which can provide unnecessary lock contention in threaded applications.
The main downsides are:
- More code on our end
- Some magic. When used on a
Struct
type, thecached_property
implementation itself won't ever actually run, it's just a decorator flag to tell theStruct
implementation to treat it as a cached property using our own implementation. Sinceattrs
is already doing the same, I feel better following their lead.
from msgspec.
- Some magic. When used on a
Struct
type, thecached_property
implementation itself won't ever actually run, it's just a decorator flag to tell theStruct
implementation to treat it as a cached property using our own implementation. Sinceattrs
is already doing the same, I feel better following their lead.
What about not using functools.cached_property
, but instead provide e.g. msgspec.cached_property
, which would work the same way you described, but would make it more explicit that this is not the same as the functools one? That would eliminate the magic aspect of it while providing the same functionality.
from msgspec.
Related Issues (20)
- ormsgpack benchmark comparison HOT 1
- encode sort_keys argument HOT 16
- Allow more than one str-like type in unions HOT 5
- decode's strict=False does not cast floats to ints HOT 3
- Typed encoding HOT 1
- Validation on serialization HOT 5
- Make msgspec more aware of large data and other serialization protocols
- Recommendation for Efficiently Decoding BSON from PyMongo with msgspec
- leading underscores and `"camel"` rename strategy HOT 2
- Constraint check for typing.Optional field HOT 1
- UnboundLocalError for `new_scope` HOT 3
- Sign release tags when making future releases? HOT 4
- How can I do data normalization on a frozen instance in `__post_init__`? HOT 1
- Cannot convert with `from_attributes` when using a rename convention HOT 3
- Cannot set `gc=False` on Generic structs? HOT 5
- Support types.MappingProxyType HOT 3
- Add either `init_omit_defaults` or `omit_none` HOT 8
- Consider making `DecodeError` and `ValidationError` inherit from `ValueError` HOT 1
- Docs page on testing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from msgspec.