Feature request/bug: Display 1 CD as a default when no "disc" tag is present about mympd HOT 14 CLOSED

Hi, sorry to bother you again but I updated to the 11.0.3 version and it seems that I still have the counter set to 0 for some of my albums.

Regards

from mympd.

You must force the recreation of the album cache. You can do it in the maintenance dialog.

from mympd.

Thanks, will do 👍

from mympd.

For me all the albums are shown as having '1 Disc', including the ones with more than 1 CD

All my music are FLAC files, and only the multi disc albums have the DISC=n vorbis tag. The disc tag is enabled in mpd.

what could be the problem?

from mympd.

MPD shows the tracks with the correct disc number?

from mympd.

Yes.

mpc --format='%disc% %track%_%title%' search '((artist == "Amy Winehouse") AND (album == "Back to Black"))'
1 1_Rehab
1 2_You Know I'm No Good
1 3_Me & Mr Jones
1 4_Just Friends
1 5_Back to Black
1 6_Love Is a Losing Game
1 7_Tears Dry on Their Own
1 8_Wake Up Alone
1 9_Some Unholy War
1 10_He Can Only Hold Her
1 11_Addicted
2 1_Valerie
2 2_Cupid
2 3_Monkey Man
2 4_Some Unholy War
2 5_Hey Little Rich Girl
2 6_To Know Him Is to Love Him
2 7_Love Is a Losing Game (original demo)

from mympd.

I will check this after my holiday.

from mympd.

Sure, no rush. Enjoy

In the mean time I did a little debugging, and found out that this function call is always returning NULL

maybe the custom library libmpdclient that is included in the project in to blame?

from mympd.

Have you enabled the disc tag in myMPD? Displays myMPD in other places the right disc number?

from mympd.

Yes the disc tag is enabled in the settings.

In the album details it displays the disc number, but not when browsing.

from mympd.

Ok, I think I know the root cause. myMPD does not enable the disc tag for building the album cache.

from mympd.

"it is quite common to not have any "disc" tag in the files", yes correct, and if there are none then none should be displayed (e.g. with a line, like in the play view when a tag is enabled but not present).
Showing an invented disc number if there is none (and no physical CD involved) is not correct, IMHO.

from mympd.

I add an option how myMPD should interpret a missing disc tag.

from mympd.

Bug is fixed, the switch will be added for the 12.0.0 release.

from mympd.