Code Monkey home page Code Monkey logo

Comments (2)

rwst avatar rwst commented on July 18, 2024

there IS a check for connectivity in cleanup() before structure layout, but it only triggers after the hydrogen placer placed missing hydrogens. The question is, is it safe to make the hydrogen placer PART OF the connectivity checking to catch these cases, maybe use a dummy to avoid side effects on the checked molecule?

from jchempaint.

rwst avatar rwst commented on July 18, 2024

Reason was all H atoms were deleted in cdk.layout.StructureDiagramGenerator:258 which makes this a CDK issue.-
The relevant tracker entry / pull request are
https://sourceforge.net/tracker/?func=detail&aid=3555353&group_id=20024&atid=320024
and
https://github.com/rwst/cdk/commit/1659dadc0f5050dd462cec73170944fded44665e

from jchempaint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.