Can pushy drain "public queue" as well when PushManager#shutdown() is called? about pushy HOT 6 CLOSED

Why does pushy not drain publicQueue when shutdown() is called?

We don't completely control the public queue, so we don't know when it might become empty. If somebody tries to shut down pushy, but continues to enqueue notifications, we might never finish shutting down. It seemed like a choice between evils, and "sending stopped sooner than expected" seems slightly better than "pushy never shut down."

Is there a plan to drain publicQueue at next iteration?

Not right now, but we're open to arguments that we should do so.

Is there a recommended way of draining publicQueue when shutdown() is called?

It hasn't really come up yet, honestly. One possibility that springs to mind is subclassing a blocking queue and adding methods to notify listeners when the queue becomes empty.

…it wasn't quite obvious to me from pushy documentation that publicQueue will NOT be drained until I wrote an integration test.

Well, that's clearly a problem regardless of whatever else we decide to do. We'll see what we can do to clear things up there.

from pushy.

@jchambers Thanks for your response! 👍

from pushy.

If you don't mind, I'd like to keep this open until the docs actually get reviewed/updated (so we don't forget).

from pushy.

No, I don't mind at all 👍

from pushy.

With apologies for the delay, the PushManager docs have been updated in 1711586.

from pushy.

Thanks! :-) 👍

from pushy.