Change number of netty IO threads for feedback client about pushy HOT 2 CLOSED

Another thought on this, but for the regular ApnsClientThread. Since pushy already creates a thread per connection, it might make sense to set the netty group to only 1 thread. For example, right now on my machine (8 core), a pushManager with 1 thread will end up creating 16 threads for netty. The other 15 threads for netty will be wasted.

Is there any benefit to having netty use more than 1 thread when pushy already has a thread per connection?

Or should the ApnsClientThread share the same bootstrap group for all ApnsClientThreads? (I know this one is definitely not simple)

from pushy.

This is somewhat of a waste since pushy will only use 1 connection for the feedback service (it's obviously pointless to use more than one).

Definitely true.

Is there any benefit to having netty use more than 1 thread when pushy already has a thread per connection?

Nope. This has actually been a TODO in my head for a while. Didn't realize quite how many threads we were using, though, so thanks for calling attention to it. #10 should do the easy stuff. I'd love to condense everything into a single bootstrap group, but will save that for a future enhancement.

from pushy.