tokenStringToByteArray throws NullPointerException in 2 cases about pushy HOT 7 CLOSED

A NullPointerException for an odd string length is clearly a goof on our part; sorry about that. I'm just struggling to come up with a good name for the exception. I'm hesitant to use "valid" anywhere in the name because the gateway can reject tokens as being "invalid" after we've declined to throw an exception locally. How about IllegalTokenStringException?

from pushy.

…also, I'd buy you a beer to find out how you're winding up with odd-length token strings ;)

from pushy.

To confirm you're getting a NullPointerException with an odd string length? Not a StringIndexOutOfBoundsException?

from pushy.

MalformedTokenException?

On Mon, May 19, 2014 at 5:39 PM, Jon Chambers [email protected]:

…also, to confirm you're getting a NullPointerException with an odd
string length? Not a StringIndexOutOfBoundsException?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/88#issuecomment-43527289
.

from pushy.

@jchambers

1. IllegalTokenStringException sounds good.
2. A beer sounds awesome, but no need :-) I am building an internal service that exposes REST API. The API accepts a payload( message and a device token ) and pushes it to APNS. And sometimes a client of my service sends a device token of odd length, probably by mistake.
3. My bad. Yes, it is StringIndexOutOfBoundException, not NullPointerException

Thanks!

from pushy.

#90 should fix this.

from pushy.

#90 has been merged.

from pushy.