Optimize APNs payload construction about pushy HOT 8 CLOSED

I think another point that can be arguable is using Jackson library instead of json-simple in that optimization process.

from pushy.

@okohub Can you elaborate? Why would that help?

from pushy.

ApnsBuilder is complicated. There are lots of things in a one "builder" class. Creating a JSON from builder result is also complicated i think. First of all, using a better library for JSON serializing and dividing core part to POJOs will help developers to improve pushy. Jackson is very powerful at POJOs. You don't have to check attribute is existing or not for serializing, for example.

from pushy.

You don't have to check attribute is existing or not for serializing, for example.

The APNs payload is a tricky beast. In some cases, these things are all interpreted differently by the receiving device:

1. An attribute is present and has a non-null value
2. An attribute is present and its value is null
3. An attribute is not present

Jackson (or other libraries) that work by serializing POJOs deprive us of the expressive flexibility we need to reach all of those cases (i.e. there isn't a good way to differentiate between "present and null" and "not present").

from pushy.

Just an idea that when builder is called maybe the length+key length shall be calculated on the spot.
For example, builder.badge(10) increase length by 5(badge) + 1":" + 2(10). And consider the {} together, when build() is called the length shall be evaluated immediately, cause the key and symbols is predefined.

from pushy.

I've been looking through changelogs while updating our dependency and seen this:

Jackson (or other libraries) that work by serializing POJOs deprive us of the expressive flexibility we need to reach all of those cases (i.e. there isn't a good way to differentiate between "present and null" and "not present").

Jackson is not limited to pojo processing mode: there are other modes, such as Tree Model. Take a look at the 'Constructing Tree Model instances from Scratch' section.

from pushy.

FWIW, we switched to Gson a while ago.

from pushy.

Yeah, sorry, totally didn't see the date of that comment.

from pushy.