Comments (3)
I think I found the bug. In the anneal method, where one of the children is empty, these lines
if (closerSize == 0 || fartherSize == 0) {
// One of the child nodes has become empty, and needs to be pruned.
this.points = new ArrayList<>(closerSize + fartherSize);
this.addAllPointsToCollection(this.points);
mean that the test for this.points == null
in addAllPointsToCollection
fails. Something like this works
if (closerSize == 0 || fartherSize == 0) {
// One of the child nodes has become empty, and needs to be pruned.
ArrayList<E> children = new ArrayList<>(closerSize + fartherSize);
this.addAllPointsToCollection(children);
this.points = children;
from jvptree.
I think you're right and will follow up shortly.
It's funny—I was actually thinking the other day that the "anneal" process is so complicated and inefficient that it really ought to change or go away. A challenge for another time, though.
from jvptree.
Thanks!
"anneal" would be a lot simpler if you didn't need to worry about points being removed from the tree.
Just to make things a bit more complicated ... I was thinking a bit more about the pruning logic. It's possible that a new vantage point could be chosen in that step? When you construct the tree every vantage point is one of the points inserted into the tree. That won't be the case when you start removing things?
from jvptree.
Related Issues (6)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jvptree.