ConstPool is limited to 32767 entries about jboss-classfilewriter HOT 6 CLOSED

Maybe we should also add a check whether a constPoolSize exceeds the limit?

from jboss-classfilewriter.

That was quick, thanks! ;-)

from jboss-classfilewriter.

Do you need a release with this?

from jboss-classfilewriter.

It seems org.jboss.classfilewriter.code.CodeAttribute.writeShort(int) should probably only fail if n > Short.MAX_VALUE * 2.

By the way, b2eb9f0 breaks weld on few places. org.jboss.classfilewriter.code.CodeAttribute.anewarray(String) previously accepted a class name, e.g. java.lang.Class. Now it fails with:

Caused by: java.lang.RuntimeException: invalid descriptor [Ljava.lang.Class;
    at org.jboss.classfilewriter.code.StackEntry.<init>(StackEntry.java:68)
    at org.jboss.classfilewriter.code.StackEntry.of(StackEntry.java:115)
    at org.jboss.classfilewriter.code.StackState.push(StackState.java:93)
    at org.jboss.classfilewriter.code.StackFrame.replace(StackFrame.java:138)
    at org.jboss.classfilewriter.code.CodeAttribute.anewarray(CodeAttribute.java:233)

from jboss-classfilewriter.

The same applies to org.jboss.classfilewriter.code.CodeAttribute.exceptionBlockStart(String) and maybe other methods...

A simple fix is to do type.replace('.', '/') on a param but it might deserve a more systematic approach :-).

from jboss-classfilewriter.

@stuartwdouglas Thanks again :-)

from jboss-classfilewriter.