Emit a "connectionError" event when the WebSocket connection fails about gremlin-javascript HOT 5 CLOSED

Thanks - I just pushed a commit. I take a lot of inspiration from node_redis so I named the event error (see https://github.com/NodeRedis/node_redis#connection-events).

I also need to add a way to automatically reconnect. Using https://www.npmjs.com/package/retry could help, but I need to give it more thought.

from gremlin-javascript.

Thank you for the swift fix. However, the 'error' event is already used for query errors, so any use-case that I can think of would need an if inside the event handler to differentiate connection errors from query errors.

Example:

function connectClient = function(host, port, done) {
  var client = gremlin.createClient(host, port);
  client.on('connect', function() {
    done(null, client);
  }).on('error', function(err) {
    // could be a query error after connection has already succeeded
   if (!client.connected) {
     done(err);
   }
  });

I believe it would be much simpler to have different event names for connection errors and query errors.

from gremlin-javascript.

Ah, I see what you mean. Let me think that through, there might indeed be a better way to name that event or to distinguish between client events and query (= ReadableStream) events.

from gremlin-javascript.

I'm thinking about adding a disconnect event at the client level (= Websocket disconnection errors) in order to distinguish from the current error event which can be emitted by result steams when using the .stream() API. Unless I'm mistaken, the client instance doesn't emit an error event should a stream error actually occur, though I might be wrong on that one - I'll have to check/test that.

Feel free to provide feedback!

from gremlin-javascript.

I'm no t sure about the  disconnect semantics as this can happen if connection never took place (e.g.: tried to connect but failed because the provided port was wrong).

from gremlin-javascript.