Total number of records should be changeable. about react-data-table-component HOT 7 CLOSED

Ok, I'll be adding a new optional property named paginationTotalRows that can be used to override data.length. In addition, onChangePage will return both the current index and total row count so it can also be accessed within that callback.

Thanks for finding this issue @prince3339 . I'll also need to add a new demo for server-side pagination but will do that in a separate issue

from react-data-table-component.

@jbetancur
Thanks for taking this issue seriously.
And I'm happy to contribute 😊 here.

from react-data-table-component.

Hello @prince3339,

I'm not completely clear on what you are asking for. Do you just need the callback for Pagination to return the total number of records? Can you give me a workflow or code sample of what you are trying to achieve?

from react-data-table-component.

Hey @jbetancur,
In this library, you are setting total page number based on data length. But in my case I don't have all the data in the first place. I know the total records from the query. Say in database there 200 records. I know that number.
Now say, I have set the page limit 20. So in one query/api call I get 20 records. And total page should be Math.ceil(200/20).
Here the problem arises. Instead of Math.ceil(total records(200)/20), you are doing Math.ceil(Data.length/20). So I won't be able to get all my data based on correct pagination.

I hope you understand now.

from react-data-table-component.

Yea, I see the issue now. The code assumes that you are paging a fixed row total count, but is not accounting for the case where an actual pagination API query is being performed.

I'll see about providing a new property.

from react-data-table-component.

Closed by #80

from react-data-table-component.

@prince3339 no problem! Of course, contributions are always welcome! 👍

from react-data-table-component.