Warning django 1.9 about django-user-sessions HOT 11 CLOSED

Django 1.9 is a development release, which is currently not supported. Once Django 1.9 matures support will be added in this package. Feel free to submit a pull request to resolve this issue, otherwise stick with 1.8.

from django-user-sessions.

This warning is present in 1.8, the only workaround I've found is if you don't comment out 'django.contrib.sessions' under INSTALLED_APPS and just put user_sessions underneath it and things still work as expected, but I'm not sure yet what side-effects that might have.

from django-user-sessions.

As written above, you'll have a sql table created.

from django-user-sessions.

This warning is triggered because user_sessions.models imports django.contrib.sessions.models.SessionManager which is in the same module as d.c.s.models.Session. However, even if SessionManager was in another module, it uses d.c.s.db.SessionStore, which also imports d.c.s.models.Session.

The only way I could find to avoid this, is to copy/paste SessionManager into user_serssions.models, but that

1. introduces code duplication
2. introduces a need to do a database migration

diff --git a/user_sessions/models.py b/user_sessions/models.py
index 1f646d1..eab6dfe 100644
--- a/user_sessions/models.py
+++ b/user_sessions/models.py
@@ -1,10 +1,27 @@
 import django
 from django.conf import settings
-from django.contrib.sessions.models import SessionManager
 from django.db import models
 from django.utils.translation import ugettext_lazy as _


+class SessionManager(models.Manager):
+    use_in_migrations = True
+
+    def encode(self, session_dict):
+        """
+        Returns the given session dictionary serialized and encoded as a string.
+        """
+        return SessionStore().encode(session_dict)
+
+    def save(self, session_key, session_dict, expire_date):
+        s = self.model(session_key, self.encode(session_dict), expire_date)
+        if session_dict:
+            s.save()
+        else:
+            s.delete()  # Clear sessions with no data.
+        return s
+
+
 class Session(models.Model):
     """
     Session objects containing user session information.

from django-user-sessions.

Django 1.9 was recently released, and the above warning is now a hard error that prevents the application from starting. It would be helpful to fix this.

from django-user-sessions.

I've started making some other fixes for Django 1.9 in a fork: #48. It's still a work in progress though.

from django-user-sessions.

Thanks everyone, I've merged #40 and pushed additional fixes as well; available in master.

from django-user-sessions.

Thank you everyone, will this code be available as 1.3 tag?

from django-user-sessions.

Seeing that there are some backwards incompatible changes, it'll probably be released as a minor release (1.3 is up next).

from django-user-sessions.

Sorry for asking again.
Should we use the master branch version for our requirements files or a specific tag will be added?
1.2.1 tag?

from django-user-sessions.

That's entirely up to you; the master branch is under development, your mileage might vary.

from django-user-sessions.