Code Monkey home page Code Monkey logo

Comments (10)

claudep avatar claudep commented on August 26, 2024 1

In version 4, we migrated from TinyMCE 5 to TinyMCE 6. Search for formatselect on https://www.tiny.cloud/docs/tinymce/6/migration-from-5x/ and you will find your answer!

from django-tinymce.

claudep avatar claudep commented on August 26, 2024 1
  • checklist, casechange, permanentpen, formatpainter, insertfile, pageembed, template, a11ycheck, showcomments, addcomment are only available for paid TinyMCE subscriptions. I'll remove them from the docs.
  • emoticons, save, codesample are plugins and should be mentioned under the "plugins" key. ltr and rtl need the directionality plugin.

Thanks a lot for your review ❤️, I'll suggest a second patch for these updates.

from django-tinymce.

urzbs avatar urzbs commented on August 26, 2024

Thank you for the quick help!
replaced formatselect with blocks

TINYMCE_DEFAULT_CONFIG = {
    "theme": "silver",
    "height": 500,
    "menubar": False,
    "plugins": "advlist,autolink,lists,link,image,charmap,print,preview,anchor,"
               "searchreplace,visualblocks,code,fullscreen,insertdatetime,media,table,paste,"
               "code,help,wordcount",
    "toolbar": "undo redo | blocks | "
               "bold italic backcolor | alignleft aligncenter "
               "alignright alignjustify | bullist numlist outdent indent | "
               "removeformat | help",
}

The default for TINYMCE_DEFAULT_CONFIG (when not specified in settings.py) is the old schema
Also the documentation examples:
https://django-tinymce.readthedocs.io/en/latest/installation.html#configuration

from django-tinymce.

claudep avatar claudep commented on August 26, 2024

Oh yes, absolutely, we need to fix that!

from django-tinymce.

claudep avatar claudep commented on August 26, 2024

Would you like to check the pull request referenced above?

from django-tinymce.

urzbs avatar urzbs commented on August 26, 2024

The pull request looks good to me for this issue in particular.

However, I have also cross-checked the more extensive example with version 3.7.1 to test if there are any elements (in the toolbar) missing.

Yes, there are. Additionally, there is a mismatch between:

  • OLD: fontsizeselect

  • NEW: fontsize

  • OLD: fontselect

  • NEW: fontfamily

So, the updated configuration should be:

TINYMCE_DEFAULT_CONFIG = {
    "height": "320px",
    "width": "960px",
    "menubar": "file edit view insert format tools table help",
    "plugins": "advlist autolink lists link image charmap print preview anchor searchreplace visualblocks code "
               "fullscreen insertdatetime media table paste code help wordcount spellchecker",
    "toolbar": "undo redo | bold italic underline strikethrough | fontfamily fontsize blocks | alignleft "
               "aligncenter alignright alignjustify | outdent indent | numlist bullist checklist | forecolor "
               "backcolor casechange permanentpen formatpainter removeformat | pagebreak | charmap emoticons | "
               "fullscreen preview save print | insertfile image media pageembed template link anchor codesample | "
               "a11ycheck ltr rtl | showcomments addcomment code",
    "custom_undo_redo_levels": 10,
    "language": "es_ES",  # To force a specific language instead of the Django current language.
}

(matching yours)

However, I have noticed that in both versions, you don't see any interactable changes in the toolbar for the following items:

  • checklist
  • casechange
  • permanentpen
  • formatpainter
  • emoticons
  • save
  • insertfile
  • pageembed (no effect, media submenu)
  • template
  • codesample
  • a11ycheck
  • ltr
  • rtl
  • showcomments
  • addcomment

I'm not sure if these require any other special treatment to show up.


The menu bar seems fine, but I can't guarantee I didn't miss something 🤣

from django-tinymce.

claudep avatar claudep commented on August 26, 2024

Updates suggested in pr #472

from django-tinymce.

urzbs avatar urzbs commented on August 26, 2024

Thank you for addressing this issue so promptly and professionally. Your quick and efficient handling of the matter was truly extraordinary.

This experience has significantly increased my trust in the django-tinymce project, and I look forward to its ongoing support and development.

from django-tinymce.

claudep avatar claudep commented on August 26, 2024

Thanks for your kind words!

from django-tinymce.

claudep avatar claudep commented on August 26, 2024

I think we can consider now this as fixed. Thanks very much for the report.

from django-tinymce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.