Not sending lockout signal about django-axes HOT 9 CLOSED

I proposed a patch that triggers the correct actions, but somehow it does not pass the Travis CI build.
If someone has thoughts about it it would be welcome, since I'd like to use this library in a project, but the signal's spawn is mandatory for my needs.
zoten@f3f9371

from django-axes.

+1 for this issue - code never hits the signal send line because of the is_already_locked check above it, and the fact that
failures > FAILURE_LIMIT
is never True: failures gets capped at 5 with FAILURE_LIMIT = 5, and is_already_locked() prevents reaching this logic a 2nd time.

it would be really nice to have access to this lockout signal to be able to customize site behavior at the moment of user lockout (e.g. notify admin or record suspicious activity).

from django-axes.

@zoten Where is your PR? I don't see it.

from django-axes.

@aclark4life I think it has been rejected because it seemed to break some tests, which I hadn't the time to fix.
You can still find the one-line-diff at
zoten@f3f9371

from django-axes.

Jep, this issue would also be important for me.

from django-axes.

Great job!

from django-axes.

@zoten thanks for fixing this weird bug!
@aclark4life are you going to release a new version soon? Thanks!

from django-axes.

Done! https://pypi.python.org/pypi/django-axes/1.4.0

from django-axes.

@aclark4life thank you sooo much! 😄

from django-axes.