Code Monkey home page Code Monkey logo

Comments (5)

iliakan avatar iliakan commented on June 11, 2024 1

Such a well-delivered bug report calls for immediate reaction! 🚀

The problem was that SVG had a bit different text. And there was also a file duplicate.

I fixed it in the repo and submitted the correct images.yml.

Also, added more troubleshooting hints at https://github.com/javascript-tutorial/server#troubleshooting-images-translation.

from server.

iliakan avatar iliakan commented on June 11, 2024 1

from server.

jonnathan-ls avatar jonnathan-ls commented on June 11, 2024

@iliakan Could you help?

from server.

jonnathan-ls avatar jonnathan-ls commented on June 11, 2024

#87 (comment)
Such a well-delivered bug report calls for immediate reaction! 🚀
The problem was that SVG had a bit different text. And there was also a file duplicate ...

@iliakan 🙇‍♂️ perfect

Thanks for the quick response and additional troubleshooting guidance on translating images.

I was able to understand better and replicate it in another image that had a translation in progress.

The script to get the strings from a file (SVG) is essential.

If I may make a suggestion?

It would even be nice to add the command to obtain the strings as a mandatory step in the translation process, if we are going to follow the guidance only looking directly at the SVG, it ends up allowing for a margin of error, but with the script, just copy the result and use it as keys in the YML file

Why the suggestion?

It took me a while to get the translation of the file ifelse.svg for example.

/1-js/02-first-steps/10-ifelse/2-check-standard/ifelse_task2.svg

This is because, at first, (thinking it would be possible to translate the entire text) ... I looked directly at the SVG file and identified, for example, the following text What's the “official” name of Javascript? as follows:

What's the “official” name of JavaScript?

I realized then that I would need to isolate each text snippet by separating them by the html elements (which is already provided by the script you guided to use)

image

Note

There are some relevant remarks, since the characters need to match exactly as the script expects to read, because:

  • Some characters appeared in a specific encoding format, which cannot be used in translation
  • In the visual format, there is a double quote character ", but looking carefully, the character is different (I can't tell if it's due to my OS - MAC)

The final result of implementing the translation in the images.yml file looks like this:

ifelse_task2.svg:
  Begin:
    text: Início
    position: center
  What's the:
    text: Qual o nome
    position: center
  “official” name of:
    text: nome "oficial" do
    position: center
  Other:
    text: Outro
    position: center
  You don't know?:
    text: Você não conhece?
    position: left
  Right!:
    text: Correto!
    position: center

from server.

jonnathan-ls avatar jonnathan-ls commented on June 11, 2024

Thank you for the valuable insights! Could you suggest a PR for the Readme https://github.com/javascript-tutorial/server/blob/master/README.md ?

Sure ... pull request submitted: #88

from server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.