Code Monkey home page Code Monkey logo

Comments (11)

tipsy avatar tipsy commented on August 18, 2024

I don't think a lot of people read release notes unprompted (the link used to be in the top bar, and less than 1% of users clicked on it. The purpose of the news pages is more to act as an entry point to the website. This box is arguably more important than the post itself.

Screen Shot 2023-03-09 at 16 35 13

from javalin.github.io.

dzikoysk avatar dzikoysk commented on August 18, 2024

It still sounds like a valid point to stop using this in a way it is atm. I'd just move to GitHub releases, it'd be more consistent with how projects are managed on this platform in general + that's how our plugins are released, so it'd be even more consistent between projects in the org. The news may stay hidden as it is now, you'd just leave a link to GitHub releases below this box.

from javalin.github.io.

tipsy avatar tipsy commented on August 18, 2024

I don't mind linking to release from a news post, but we probably need to rework our commit messages to get the most out of this?

from javalin.github.io.

dzikoysk avatar dzikoysk commented on August 18, 2024

Umm it depends, for quite a long time I was writing release notes manually, lately they've added a basic generator, but I think it's up to you how you want to present that. I don't really mind either way, my point here is to just keep it there.

Speaking of the migration, I think it'd be nice to move older releases there as well - we could move all of them or just e.g. all from 3.x/4.x. News are in markdown:

So we could just basically copy-paste this content there.

from javalin.github.io.

zugazagoitia avatar zugazagoitia commented on August 18, 2024

I agree with @dzikoysk, I like having releases here.

Since you're already creating tags for each release, it's trivial to automatically generate a release using GitHub actions with the commits.

I use ncipollo/release-action for example.

from javalin.github.io.

tipsy avatar tipsy commented on August 18, 2024

But should we then also switch to https://www.conventionalcommits.org/en/v1.0.0/ (or something similar) to get the most out of this setup?

from javalin.github.io.

zugazagoitia avatar zugazagoitia commented on August 18, 2024

But should we then also switch to https://www.conventionalcommits.org/en/v1.0.0/ (or something similar) to get the most out of this setup?

Late reply but seems like a good idea. Although you'll be the one doing the commits since you squash when merging.

from javalin.github.io.

dzikoysk avatar dzikoysk commented on August 18, 2024

I used several approaches, and I personally don't like the convention proposed in this link. The best format that works for me is probably:

Pull request title: GH-{IssueId} Description
Commit message (squash): GH-{PullRequestId} {Description} (Resolves/Fixes {RelatedIssuesIds}

It informs you not only about the type of change, but what's even more important for me, it provides realtively easy way to find associated discussion about requested change (issue) & conversation+decisions made during the impl phase (pull request).

from javalin.github.io.

zugazagoitia avatar zugazagoitia commented on August 18, 2024

I used several approaches, and I personally don't like the convention proposed in this link. The best format that works for me is probably:

Pull request title: GH-{IssueId} Description
Commit message (squash): GH-{PullRequestId} {Description} (Resolves/Fixes {RelatedIssuesIds}

It informs you not only about the type of change, but what's even more important for me, it provides realtively easy way to find associated discussion about requested change (issue) & conversation+decisions made during the impl phase (pull request).

I do agree traceability on commits/PRs is important, but its nice to know what the change does right away even if it's not related to an issue/PR.

from javalin.github.io.

zugazagoitia avatar zugazagoitia commented on August 18, 2024

We can automate using this two actions:

https://github.com/marketplace/actions/release-drafter
https://github.com/marketplace/actions/gh-release

Also, when a released is published users that choose to are notified.

from javalin.github.io.

tipsy avatar tipsy commented on August 18, 2024

This has largely been done now.

from javalin.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.