Code Monkey home page Code Monkey logo

Comments (3)

Pachtjuilaard avatar Pachtjuilaard commented on September 27, 2024

Additional info: I was rolling only one die. When rolling two dice, the plugin works as expected. So, when rolling one die and you keep the lowest, the single rolled result is regarded as the highest result and is dropped, leaving no dice rolled. So, this bug doesn't seem like a problem when actually used as intended (I mean, why roll one die with disadvantage?), but still a weird interaction nonetheless.

from dice-roller.

ThaddaeusWiedemer avatar ThaddaeusWiedemer commented on September 27, 2024

I think you might be misunderstanding the kh and kl option. These options keep the highest or lowest die out of all rolled dice. Rolling with advantage/disadvantage as in DnD means rolling two dice and keeping the highest or lowest roll, i.e., dice: 2d20kl+5 rolls with disadvantage and works as expected, dice: 2d20kh+5 rolls with advantage.

I agree however that the behavior of these options when applied to a single die is unclear and could be documented.

from dice-roller.

Pachtjuilaard avatar Pachtjuilaard commented on September 27, 2024

I know how (dis-)advantage works, it's just that I'd like for 1d20kl1 actually keeps the lowest rolled die. Now it's just being discarded, making 1d20kl1 functionally the same as 0 while the plugin is still actually rolling the die.

If "roll 1d20 and keep the lowest result" actually kept the lowest rolled die, which is just the roll itself, the behaviour of the keep lowest/highest function would be more consistent. Now the plugin is just rolling a die and putting it away before really looking at the number rolled.

from dice-roller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.