Code Monkey home page Code Monkey logo

Comments (7)

Suleiman212 avatar Suleiman212 commented on September 24, 2024

Thinking about the leap day stuff, it seems like FC has two ways of inputting leap days, either on an interval with an offset, or on set years of a cycle (you switch between them with a checkbox). Looking at the calendar editor within Calendarium itself, it seems like it doesn't have these two settings, instead it just has the first, and so when I set up leap days using the second in FC, it is being misinterpreted as the first and breaking. But it seems to me like the second case can easily be expressed in terms of the first; for example, having a 5 year cycle with a leap day on the 2nd and 4th year, is the same as one leap day with a 5 year interval offset 2 years, and one with a 5 year interval offset 4 years.
So currently Calendarium imports interval as interval, then cycle as offset, when importing the second kind of leap days, but really it should be switched to be importing interval as offset then cycle as interval.

from calendarium.

Suleiman212 avatar Suleiman212 commented on September 24, 2024

Okay manually setting that up seems to have fixed both the leap day problem and also my moon problem...
Not sure how they were related, but maybe the leap days, when improperly defined, were overlapping or doing something weird and causing the moon to skip around...?

from calendarium.

valentine195 avatar valentine195 commented on September 24, 2024

Moon phase calculation is based on the number of days before the current day, so having leap days occurring or not occuring will change moon phases.

from calendarium.

Suleiman212 avatar Suleiman212 commented on September 24, 2024

The strange thing was that the calendar was only showing one leap day occurring, but seemed to be pushing the moon phases forward many days, as if the leap day had occurred multiple times on top of each other. So month increased from 29 to 30 days, but then the next month started about 9 days worth of phases.

from calendarium.

pixel7777 avatar pixel7777 commented on September 24, 2024

I just added the plugin and am unable to create moons. Is the idea that the moons have to be created in Fantasy Calendar and then displayed here? Is the preferred methodology to create the calendar in Fantasy Calendar and then import it?

from calendarium.

valentine195 avatar valentine195 commented on September 24, 2024

Hi @pixel7777 you should be able to create moons in the calendar creator thru settings. If you can’t, could you please open a new issue?

from calendarium.

valentine195 avatar valentine195 commented on September 24, 2024

@pixel7777 The moon creation should be fixed with v1.0.10

from calendarium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.